Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ambiguities #40

Merged
merged 26 commits into from
Nov 29, 2024
Merged

fix ambiguities #40

merged 26 commits into from
Nov 29, 2024

Conversation

putianyi889
Copy link
Contributor

@putianyi889 putianyi889 commented Jun 8, 2023

Aqua is set to check ambiguities.

Related changes:

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (1b8c2ce) to head (fee60c4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   98.39%   97.96%   -0.43%     
==========================================
  Files           2        6       +4     
  Lines         373      197     -176     
==========================================
- Hits          367      193     -174     
+ Misses          6        4       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@putianyi889 putianyi889 marked this pull request as ready for review June 10, 2023 15:14
@putianyi889 putianyi889 marked this pull request as draft November 5, 2023 09:02
@putianyi889 putianyi889 marked this pull request as ready for review November 8, 2024 18:07
@putianyi889
Copy link
Contributor Author

A crucial line somehow loses coverage. Removing the line results in failed tests. I've added a note to the line.

@putianyi889
Copy link
Contributor Author

@dlfivefifty dlfivefifty merged commit eb0e5bb into JuliaMath:master Nov 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants