-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ambiguities #40
Merged
Merged
fix ambiguities #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 98.39% 97.96% -0.43%
==========================================
Files 2 6 +4
Lines 373 197 -176
==========================================
- Hits 367 193 -174
+ Misses 6 4 -2 ☔ View full report in Codecov by Sentry. |
organise the codes
A crucial line somehow loses coverage. Removing the line results in failed tests. I've added a note to the line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aqua
is set to check ambiguities.Related changes:
NotANumber
toArgumentError
NotANumber
vsArgumentError
#38+∞
now refers toRealInfinity()
. Some+/-
test results have changed accordingly, although not consistent.Infinity
vsRealInfinity()
#39(fld|cld|div)(∞, x)
wherex<0
Aqua
tests are moved to the end of tests to make sure things work before fixing ambiguities.Complex{float} + ∞
min|max
are set to follow Julia base convention, that is,min(x,y)=x
andmax(x,y)=y
ifx==y
. This impactsℵ₀
and∞
specifically. Comparingℵ₀
and∞
#41