Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Random explicitly #270

Merged
merged 1 commit into from
Feb 14, 2024
Merged

use Random explicitly #270

merged 1 commit into from
Feb 14, 2024

Conversation

vchuravy
Copy link
Collaborator

In Julia 1.11 some work has been done to move standard libraries out of the "sysimage" and also make them upgradable (so they would no longer be strongly tied to the Julia version).
The Random stdlib is a bit special in the sense that it commits "type piracy" by overloading the Base.rand function for types that it doesn't own. An example of that is rand() which is defined in Random.
While code will still be able to call rand() etc in 1.11 without loading Random there are some performance implications that makes it so it is better to load Random up front.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0edec16) 96.56% compared to head (ced5c27) 96.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files           6        6           
  Lines         785      785           
=======================================
  Hits          758      758           
  Misses         27       27           
Files Coverage Δ
src/precompile.jl 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oscardssmith oscardssmith merged commit 4903ae3 into master Feb 14, 2024
22 of 32 checks passed
@kimikage kimikage deleted the vc/random branch April 5, 2024 17:11
@kimikage kimikage mentioned this pull request Apr 30, 2024
38 tasks
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request Apr 30, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request Apr 30, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 28, 2024
kimikage added a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 28, 2024
kimikage added a commit that referenced this pull request May 28, 2024
This also backports the changes in PR #270, #278.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants