Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce invalidations of other methods #180

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Reduce invalidations of other methods #180

merged 1 commit into from
Jun 15, 2020

Conversation

timholy
Copy link
Member

@timholy timholy commented May 4, 2020

These changes, combined with more extensive changes to Julia itself, greatly reduce latency stemming from loading FixedPointNumbers. Ref JuliaLang/julia#35733.

There will be very little benefit to this on its own, but we can at least find out if it works across Julia versions.

These changes, combined with more extensive changes to Julia itself,
greatly reduce latency stemming from loading FixedPointNumbers.
Ref JuliaLang/julia#35733.

There will be very little benefit to this on its own, but we can at
least find out if it works across Julia versions.
@kimikage
Copy link
Collaborator

kimikage commented May 4, 2020

julia> sizeof(Fixed{BigInt,10})
8

😝
This is off-topic but it doesn't seem to be well documented what sizeof should return. (https://docs.julialang.org/en/v1.4/base/base/#Base.sizeof-Tuple{Type})
I saw some troubles in the Discourse.

@kimikage
Copy link
Collaborator

kimikage commented May 4, 2020

zero, oneunit, one, typemin, typemax, floatmin, floatmax, eps, sizeof, reinterpret,

We will not need sizeof, anymore.

@timholy
Copy link
Member Author

timholy commented May 4, 2020

Oof. That's not good. I'm surprised that Core.sizeof does that.

NVM. The result is pretty much undefined when it's not inline storage. In a sense the new answer is better.

@timholy timholy merged commit 989cca4 into master Jun 15, 2020
@timholy timholy deleted the teh/invalidations branch June 15, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants