Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logabsgamma and unrelated fixes #195

Merged
merged 4 commits into from
Apr 12, 2024
Merged

add logabsgamma and unrelated fixes #195

merged 4 commits into from
Apr 12, 2024

Conversation

araujoms
Copy link
Contributor

Fixes #183

Also fixed the shadowing functions, it turned out that the syntax was correct, but loggamma and ellipk were missing from specialfunctions.jl.

And also fixed an unrelated typo in sqrt_dd_dd that was preventing compilation.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.42%. Comparing base (2b0e173) to head (91c5278).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   50.02%   50.42%   +0.39%     
==========================================
  Files          63       63              
  Lines        3546     3536      -10     
==========================================
+ Hits         1774     1783       +9     
+ Misses       1772     1753      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeffreySarnoff
Copy link
Member

Thank you. I have to wait for two pending updates to merge, not automatically, then I can do this one.

@araujoms
Copy link
Contributor Author

On a second thought, it's better to write it directly in terms of lgamma. I've also realized that defining loggamma explicitly is not necessary, as the SpecialFunctions version works when we have a logabsgamma. I've also added some tests, copied from Quadmath.

@araujoms
Copy link
Contributor Author

araujoms commented Apr 4, 2024

On a third thought, perhaps it's better to directly use the logabsgamma from Quadmath instead of copy-pasting the code here. That would require changing the compat to whatever version they release after merging JuliaMath/Quadmath.jl#72, are you ok with it?

@araujoms
Copy link
Contributor Author

araujoms commented Apr 5, 2024

Ok, done. I've also noticed that Float128(Double64(Inf)) is nan instead of inf, I'm not sure whether this is a problem.

@araujoms
Copy link
Contributor Author

I'm sorry, may I ask what is the hold up?

@JeffreySarnoff
Copy link
Member

needed the reminder -- thank you

@JeffreySarnoff JeffreySarnoff merged commit f35f1c7 into JuliaMath:main Apr 12, 2024
7 checks passed
@JeffreySarnoff
Copy link
Member

JeffreySarnoff commented Apr 12, 2024 via email

@araujoms araujoms deleted the incgamma branch April 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compute incomplete gamma function for some arguments
2 participants