Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deprecation warning on LU #66

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Prevent deprecation warning on LU #66

merged 2 commits into from
Jan 12, 2023

Conversation

KnutAM
Copy link
Contributor

@KnutAM KnutAM commented Jan 12, 2023

I get this deprecation warning from my tests:

┌ Warning: `LU{T, S}(factors::AbstractMatrix{T}, ipiv::AbstractVector{<:Integer}, info::BlasInt) where {T, S}` is deprecated, use `LU{T, S, typeof(ipiv)}(factors, ipiv, info)` instead.
│   caller = ip:0x0
└ @ Core :-1

(I don't understand why, but I don't see it when calling from the REPL)
As far as I can see, there is no need to provide any type-params to LU
(Sorry if I'm way off here, just wanted to avoid the warning during my tests. I suppose it isn't so crucial as the comment in LU says will be deprecated at Julia 2.0)

@chriselrod
Copy link
Contributor

chriselrod commented Jan 12, 2023

(I don't understand why, but I don't see it when calling from the REPL)

Run julia --help

Switches (a '*' marks the default value, if applicable; settings marked '($)' may trigger package precompilation):

 --depwarn={yes|no*|error}  Enable or disable syntax and method deprecation warnings (`error` turns warnings into errors)

no is the default, but tests run with yes.

@KnutAM
Copy link
Contributor Author

KnutAM commented Jan 12, 2023

Aha, thanks!

@chriselrod chriselrod merged commit 6200e94 into JuliaLinearAlgebra:master Jan 12, 2023
@KnutAM KnutAM deleted the patch-1 branch January 12, 2023 21:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants