-
Notifications
You must be signed in to change notification settings - Fork 3
Use BLIS 2.0 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BLIS 2.0 #19
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 1 1
Lines 12 12
=======================================
Hits 11 11
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I was able to fix the blis build by forcing the arch to be |
|
Sounds like the SVE kernels in BLIS might have an issue on the M-series chips. I don't have one to try locally, unfortunately, so I guess firestorm is good enough for now. |
Well, Apple Silicon doesn't have SVE, they also accurately avoided in M4 which is armv9, causing a mess in clang. |
Huh, I thought they had SVE in the M series. I wonder if this points to a problem with autodetection logic in BLIS then where it tries to use the wrong kernels and can't get the proper paramters. |
It seems like Yggdrasil build of BLIS for mac aarch64 has some problems, which are not obvious from the logs. Given that things work fine on x64 on linux and windows, I am now thinking there's some problem with the default build on mac.
We also have some patches we carry from BLIS 1.0 and while they apply fine, I am not sure if they are required. Could those be causing the problems we are seeing?
cc @imciner2 @giordano