Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual build instructions #69

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

blegat
Copy link
Contributor

@blegat blegat commented May 15, 2019

Add instructions on how to link to a manual installation of the library.
It may help with #5 which is still an issue for ArchLinux and the method mentioned in the ArchLinux wiki is incorrect as detailed in #5 (comment)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 121

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.357%

Totals Coverage Status
Change from base Build 119: 0.0%
Covered Lines: 183
Relevant Lines: 280

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 15, 2019

Pull Request Test Coverage Report for Build 122

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+19.8%) to 85.116%

Files with Coverage Reduction New Missed Lines %
src/Arpack.jl 1 81.61%
Totals Coverage Status
Change from base Build 119: 19.8%
Covered Lines: 183
Relevant Lines: 215

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #69 into master will increase coverage by 19.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #69       +/-   ##
===========================================
+ Coverage   65.35%   85.11%   +19.75%     
===========================================
  Files           2        2               
  Lines         280      215       -65     
===========================================
  Hits          183      183               
+ Misses         97       32       -65
Impacted Files Coverage Δ
src/libarpack.jl 87.5% <0%> (+6.92%) ⬆️
src/Arpack.jl 81.6% <0%> (+31.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d29b6cc...eb74095. Read the comment docs.

@andreasnoack
Copy link
Member

Thanks. It would be great if you could expand it to general installation instructions explaining that for most users, it should be fine just to add Arpack or something like that?

@blegat
Copy link
Contributor Author

blegat commented Jul 12, 2019

@andreasnoack I have added general instructions

@ViralBShah ViralBShah merged commit 53e0427 into JuliaLinearAlgebra:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants