Support argmin, argmax, var, std, mean - #178
Merged
Merged
Conversation
krasow
force-pushed
the
more-reductions
branch
from
August 14, 2026 05:09
f14d67e to
720dad0
Compare
ejmeitz
force-pushed
the
more-reductions
branch
from
August 14, 2026 16:45
262b45a to
199f0b3
Compare
ejmeitz
force-pushed
the
more-reductions
branch
from
August 14, 2026 18:18
199f0b3 to
a253222
Compare
krasow
force-pushed
the
more-reductions
branch
from
August 14, 2026 19:16
a253222 to
7ca0159
Compare
krasow
force-pushed
the
more-reductions
branch
from
August 14, 2026 19:51
7ca0159 to
77b0e0f
Compare
krasow
force-pushed
the
more-reductions
branch
from
August 14, 2026 21:22
77b0e0f to
0fbc743
Compare
krasow
force-pushed
the
more-reductions
branch
from
August 14, 2026 23:17
7451b40 to
bf94fed
Compare
ejmeitz
force-pushed
the
more-reductions
branch
from
August 15, 2026 17:32
bf94fed to
97b6f4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
var,std,meanare easy.argminandargmaxare weirder cause the default legate task returns a tuple so we have to use GETARG task to avoid unwraping in the result. This is what python does and seems to work in Julia.Only support for 1D arrays on argmin/argmax.