Skip to content

Subtype AbstractArray + LinearAlgebra.Diagonal Support - #165

Open
ejmeitz wants to merge 2 commits into
developfrom
diag
Open

Subtype AbstractArray + LinearAlgebra.Diagonal Support#165
ejmeitz wants to merge 2 commits into
developfrom
diag

Conversation

@ejmeitz

@ejmeitz ejmeitz commented Aug 4, 2026

Copy link
Copy Markdown
Member

Subtyping AbstractArray means methods we do not specialize for NDArray fall back to Base or LinearAlgebra etc. This usually hits a scalar indexing error. I've updated the error message to indicate that the method might be unimplemented.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.77282% with 80 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ndarray/ndarray.jl 57.69% 44 Missing ⚠️
src/ndarray/diagonal.jl 90.90% 24 Missing ⚠️
src/warnings.jl 93.25% 6 Missing ⚠️
src/ndarray/binary.jl 57.14% 3 Missing ⚠️
src/ndarray/broadcast.jl 85.71% 2 Missing ⚠️
src/ndarray/broadcast_fusion.jl 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant