Skip to content

Remove complex type mappings for Julia #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejmeitz merged 4 commits into from
Aug 1, 2026
Merged

Remove complex type mappings for Julia #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8012850
Remove complex type mappings for Julia
ejmeitz Aug 1, 2026
ccfd4c5
add accessor tests
ejmeitz Aug 1, 2026
b07f80c
retrigger
ejmeitz Aug 1, 2026
8baceeb
retrigger
krasow Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/cunumeric_jl_wrapper/src/wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ JLCXX_MODULE define_julia_module(jlcxx::Module& mod) {
using jlcxx::TypeVar;
using legate_util::HalfType;

// Map C++ complex types to Julia complex types
mod.map_type<std::complex<double>>("ComplexF64");
mod.map_type<std::complex<float>>("ComplexF32");
mod.map_type<HalfType>("Float16");

// These are the types/dims used to generate templated functions
Expand Down
12 changes: 12 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,18 @@ include("tests/binary_tests.jl")
include("tests/scoping.jl")
include("tests/scoping-advanced.jl")

@testset "Array Accessors" begin
for T in Base.uniontypes(cuNumeric.SUPPORTED_ARRAY_TYPES)
value = rand(T)
arr = cuNumeric.zeros(T, 2, 2)

allowscalar() do
arr[1, 2] = value
@test arr[1, 2] == value
end
end
end

@testset verbose = true "AXPY" begin
N = 100
@testset verbose = true for T in Base.uniontypes(cuNumeric.SUPPORTED_FLOAT_TYPES)
Expand Down
Loading