Add User-Agent header to HTTP requests #1355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Web Application Firewalls (like CloudFront used by JuliaHub) block requests without a
User-Agent header, returning 403 Forbidden. This caused confusing
"Failed to get etag" errors when using JULIAUP_SERVER with alternate
mirrors.
Add a helper function http_client() that creates a reqwest client with
a proper User-Agent header (juliaup/{version}), and use it for all HTTP
requests on non-Windows platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Web Application Firewalls (like CloudFront used by JuliaHub) block requests without a User-Agent header, returning 403 Forbidden. This caused confusing "Failed to get etag" errors when using JULIAUP_SERVER with alternate mirrors.
Add a helper function http_client() that creates a reqwest client with a proper User-Agent header (juliaup/{version}), and use it for all HTTP requests on non-Windows platforms. Likewise for the windows HTTP client.