Open
Conversation
Collaborator
|
I think I would prefer that we just update the error message to be correct ("Something like With this PR we would never be able to switch a channel back to an older version, and when I designed this originally, I wanted to have the ability to for example pull a prematurely released build. Also, it would be good to actually understand what caused the underlying situation. I can't really wrap my head around what could have cause this, and I think I would prefer that we add diagnostic code that helps us track down what is going on with the DB versions if we encounter this situation. If we merge this PR we essentially will never be able to track down what is causing the problem in the first place.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1283
I guess the db got out of sync with the installed channels, somehow.. This seems a logical check to add.