Skip to content

Conversation

@IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Oct 30, 2025

@tecosaur

The other issue is https://github.com/JuliaLang/juliaup/actions/runs/17244028982/job/48928853337?pr=1232#step:6:263

reviewdog: This GitHub Token doesn't have write permission of Review API [1],
so reviewdog will report results via logging command [2] and create annotations similar to
github-pr-check reporter as a fallback.

So it was incorrectly green and reviewdog comments didn't get posted.

@DilumAluthge can you help resolve the token issue (I don't have settings access)

@IanButterworth
Copy link
Member Author

Seems reviewdog can't post comments on PRs from forks, so this PR is the most we can do.

@IanButterworth IanButterworth merged commit 9ad1f38 into main Oct 30, 2025
29 checks passed
@IanButterworth IanButterworth deleted the ib/rustfmt_error branch October 30, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants