Make save_config_db atomic
#1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/atomic_config_write
branch
from
dc262eb to
7862baa
Compare
|
Getting reviews here is pretty hard, but I think this is important to do, so I'm going to go ahead. Reviewers, please post merge review. |
|
This is great to see! I think this all looks good, I'm just wondering whether we actually need to keep the config files open at all, given that we have the separate lock file? I think we might be able to move to a world where on read of the config file we just 1) open file, 2) read data, 3) close file handle right away. That would make the whole write story easier on Windows, right? I think (but don't have a good memory of it) that I kept the files open originally before I added the lock file story... Maybe... Probably worth thinking through a bit more, but it could potentially simplify things, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1221
I believe this is part of #1238 which has stalled, so this just tackles not corrupting the config file.