Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base.Graphics test suite #9814

Closed
wants to merge 3 commits into from
Closed

Base.Graphics test suite #9814

wants to merge 3 commits into from

Conversation

chrisvoncsefalvay
Copy link

As it says on the tin ;) tests the following:

  • Point/Vec2 identity
  • Vec2 operations (+, -, *, /)
  • rotate() for Vec2s
  • norm()
  • BoundingBox and its attributes
  • BoundingBox ops: +, &, deform(), shift(), scale(), rotate(), with_aspect_ratio()
  • isinside() testing

This is my first official Julia contrib. Enjoy ;)

@jakebolewski
Copy link
Member

can you squash into a single commit? Otherwise LGTM. thanks!

@ViralBShah ViralBShah added the test This change adds or pertains to unit tests label Jan 17, 2015
@timholy
Copy link
Member

timholy commented Jan 20, 2015

@chrisvoncsefalvay, if you don't know how to squash, it's like this:

git rebase -i origin/master
(now change "pick" to "squash" for the second two commits)
git push [email protected]/julia.git +cvcb-cov-gr

More detail http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html. That last command is a force-push, overwriting the history on this branch.

Then ping us when it's done, so we know it's ready to merge.

@ivarne
Copy link
Member

ivarne commented Jan 20, 2015

You'll also need to resolve a merge conflict. Please ask for help if you need it.

@jakebolewski
Copy link
Member

I added this PR as a commit to the new Graphics package. Thanks @chrisvoncsefalvay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants