WIP: Better DomainError's #9693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update DomainError message for chol!(::Number)
|
How is this for performance? I suggested this a long time ago, but @JeffBezanson objected because it would cause string allocation in some critical places. |
|
It would follow the same general strategy as @vtjnash's work with BoundsErrors. The performance sensitive methods would still get special cased error handling in |
This was referenced Sep 19, 2015
|
fixed by #22751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a msg field to
DomainErrorwhich allows us to provide some context to the source of the error without special casing the error message inbase/replutil.jl. Currently theDomainError's thrown by intrinsic functions are not working properly, but I haven't worked on that part yet.