Fix #9506. Remove varargs in eigvals and eigfact. #9557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
added a commit
that referenced
this pull request
Jan 2, 2015
Fix #9506. Remove varargs in eigvals and eigfact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparantly, the compiler had problems with varargs in the promotion methods. Maybe for good reasons. I have substituted the vararg versions with versions specific for each class of matrices, e.g.
StridedMatrix,SymTridiagonal,Symmetric. It reduces code reuse, but is probably more transparent.Along the way I hit #6721, so when it is fixed, the promotion code in
symmetric.jlcan be cleaned a bit.