RFC: Should we backport #8734 to release-0.3 ? #9050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
objconv cannot do in-place modification of files dont overwrite static library with objcopy on freebsd either fix linking of arpack and suitesparse with 64_ blas suffix the patched xlahqr2 was using UPPERCASE function names, and the probes during arpack configure were using the C compiler, sgemm_ and cheev_ need to enable c preprocessor, and disable syntax error on long lines SPQR also needed -DSUN64 (backport of 1ef22d2)
(backport of 7f596d4)
(manual backport of 02ff762)
(backport of 774f3c9)
tkelman
force-pushed
the
tk/backport-8734
branch
from
081083c
to
8243c5b
Compare
|
@ViralBShah you seemed to be in favor, go/no go? Any reasons why we shouldn't do this? This shouldn't be a user-facing change at all, except that things that used to be broken due to ILP64 blas interactions should hopefully now be fixed. |
|
I am in favour of this. |
|
Dependencies change will affect distro packagers: |
|
|
tkelman
added a commit
that referenced
this pull request
Nov 19, 2014
RFC: Should we backport #8734 to release-0.3 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell this fixed #4923, and aside from a couple of Mac build issues (I've squashed the fixes for those into d297ffb, and I can squash even further if anyone would prefer that) this seems to be working fairly well on master.
Ref #9045