Better fix for #8871 #8893
Merged
Better fix for #8871 #8893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mapreduce didn't work with `Range{BigInt}`, because the length wasn't a
`Int`, because of potential overflow. This patch just converts the
length to Int with a checked conversion, because a mapreduce on larger
arrays will probably never finish anyway.
Also fix some broken test of prod
|
Works for me, thanks. |
|
@lindahua You wrote most of this part of Julia. Can you have a quick look at this, and merge if it looks good? |
|
@ivarne It looks good to me. The travis failure seems to be irrelevant. Ok, I will go ahead to merge this. |
|
Thanks! cc: @JuliaBackports (As this fixes a bug and makes other things that never worked an error.) |
ivarne
added a commit
that referenced
this pull request
Nov 4, 2014
The test added in #8893 shouldn't use typemax(Int), but typemax(Int64)
ivarne
added a commit
that referenced
this pull request
Nov 7, 2014
Mapreduce didn't work with `Range{BigInt}`, because the length wasn't a
`Int`, because of potential overflow. This patch just converts the
length to Int with a checked conversion, because a mapreduce on larger
arrays will probably never finish anyway.
Also fix some broken test of prod
(cherry picked from commit 9493465)
Fix test for 32 bit
The test added in #8893 shouldn't use typemax(Int), but typemax(Int64)
(cherry picked from commit 49083be)
|
Backported both fix, and test fix in 245b9f6 |
waTeim
pushed a commit
to waTeim/julia
that referenced
this pull request
Nov 23, 2014
The test added in JuliaLang#8893 shouldn't use typemax(Int), but typemax(Int64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapreduce didn't work with
Range{BigInt}, because the length wasn't aInt, because of potential overflow. This patch just converts thelength to Int with a checked conversion, because a mapreduce on larger
arrays will probably never finish anyway.
Also fix some broken test of prod