Describe arguments to array_resize_buffer #8492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2014
jiahao
force-pushed
the
master
branch
3 times, most recently
from
6c7c7e3 to
1a4c02f
Compare
|
Ping? This is a three-line comment, so it's either obviously correct or obviously wrong. |
| @@ -526,6 +526,9 @@ void jl_arrayunset(jl_array_t *a, size_t i) | |||
| #define MALLOC_THRESH 1048576 | |||
|
|
|||
| // allocate buffer of newlen elements, placing old data at given offset (in #elts) | |||
| // newlen: new length (#elts), including offset | |||
| // oldlen: old lenght (#elts), excluding offset | |||
|
@eschnett Can you squash these commits? @JeffBezanson Merge this? |
|
@ViralBShah With squash, you mean opening a new pull request? |
|
doesn't have to be a new PR, you can do |
eschnett
force-pushed
the
array-comments
branch
from
9469e1b to
a67f717
Compare
|
Well, here you go. |
|
I am reviewing all doc issues, and at casual look, can't tell if the comments (especially about the offset) are correct. @vtjnash @Keno @JeffBezanson may know right away and be able to merge/reject. |
timholy
added a commit
that referenced
this pull request
Jan 2, 2015
Describe arguments to array_resize_buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.