add efficient mean and median for ranges #8089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it needs a rebase |
|
Should be fixed now. |
|
Doesn't this fail for non-integer ranges? |
|
@Keno, one of the test cases is a non-integer range. Why do you think it would fail? |
|
Because |
|
@Keno, even a non-integer range has an integer |
|
Of course. My fault. |
|
Okay to merge? |
|
Not a big deal, but why don't you just let |
|
@andreasnoackjensen, right, duh. |
andreasnoack
added a commit
that referenced
this pull request
Aug 24, 2014
add efficient mean and median for ranges
|
Test time out seemed to be unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are useful (see e.g. JuliaGizmos/Interact.jl#9) and there is no reason for them not to be fast. I actually didn't realize that they were missing.