-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make (c)transpose work correctly for block matrices #7244
Conversation
This seems to me like the right thing to do. |
Oh. I didn't run the string tests locally. I'll define |
lgtm |
Or, I guess
|
I know it seems a bit sketch, but I think this is the way to go. Let's try it out and see what comes of it. |
I'll do that for now, but defining methods for |
I have sometimes wondered if we should add This is a bit sketch, but less so than making it work only for strings. |
Okay. I have added line definitions to |
I like Atom and Collection, but which does a String qualify as? |
Yep, that's one reason I didn't add those types :) You don't necessarily want to be forced to classify everything that way. |
I like this one. |
lgtm too |
Make (c)transpose work correctly for block matrices
With this change, the matrix
Apd
generated bywill be positive definite.