subtype: ignore the rest ∃ decisions if env is unchanged during local_∀_∃_subtype#61503
Merged
N5N3 merged 1 commit intoJuliaLang:masterfrom Apr 6, 2026
Merged
subtype: ignore the rest ∃ decisions if env is unchanged during local_∀_∃_subtype#61503N5N3 merged 1 commit intoJuliaLang:masterfrom
local_∀_∃_subtype#61503N5N3 merged 1 commit intoJuliaLang:masterfrom
Conversation
N5N3
added
types and dispatch
…l_∀_∃_subtype` Following up on JuliaLang#61316, this commit moves the `env_unchange` check and the reset of `Runion.more` to `local_forall_exists_subtype`, ensuring that similar optimizations are applied more broadly. Additionally, `env_unchange` now also detects diagonality changes in variables, which would fix ```julia Tuple{NTuple{2,Int}, Int8} <: Tuple{<:Union{NTuple{2,T},Tuple{S,T}}, <:T} where {S,T>:Int} ```
aviatesk
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #61316, this commit moves the
env_unchangecheck and the reset ofRunion.moretolocal_forall_exists_subtype, ensuring that similar optimizations are applied more broadly, and preventing unnecessarysave_envcost.Additionally,
env_unchangednow also detects diagonality changes in variables, which would fixTuple{NTuple{2,Int}, Int8} <: Tuple{<:Union{NTuple{2,T},Tuple{S,T}}, <:T} where {S,T>:Int}