Test: properly quote symbols and expression in evaluated output#61149
Closed
christiankadiu wants to merge 1 commit intoJuliaLang:masterfrom
Closed
Test: properly quote symbols and expression in evaluated output#61149christiankadiu wants to merge 1 commit intoJuliaLang:masterfrom
christiankadiu wants to merge 1 commit intoJuliaLang:masterfrom
Conversation
Keno
reviewed
Feb 24, 2026
| end | ||
|
|
||
| _quote_evaluated_arg(x::Union{Symbol, Expr, QuoteNode}) = Expr(:quote, x) | ||
| _quote_evaluated_arg(x) = x |
Member
There was a problem hiding this comment.
It seems like Meta.quot should maybe behave like this, but that's outside the scope of this PR.
Keno
approved these changes
Feb 24, 2026
vtjnash
requested changes
Feb 25, 2026
Author
|
Thanks @vtjnash, I completely missed #61054. I'll close this one. @Keno Thank you for the review! Regarding your comment on Meta.quot: would it be useful if I tried to implement that behavior in a separate PR? I am currently looking for issues to contribute, and I'd like to work on it if you think it's a viable task! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57287.