Unicode: Qualify Base.ismalformed when calling it#61140
Merged
oscardssmith merged 1 commit intomasterfrom Feb 26, 2026
Merged
Conversation
stevengj
approved these changes
Feb 24, 2026
Member
|
backport? |
DilumAluthge
added
backport 1.10
Member
|
Does this suggest we do not have tests for this function? |
Member
|
Yeah, would be good to have a test. |
Member
|
This function is not public, however, and only the It also doesn't seem to be used in any packages. But still, might as well have a test. |
Member
|
For example, maybe add a test like: @test Unicode.combining_class('\u0302') === 0x00e6 # combining class "Above"
@test Unicode.combining_class(reinterpret(Char, UInt32(0xc0) << 24)) === 0x0000 # malformed |
Member
|
Oops, saw approval and mergme, and tests passing and clicked merged (and just after realized that the mergme was a removal of mergme not an addition. Can the tests go in a separate PR or should I revert and remake? |
Member
Author
I think the tests can go in a a separate PR. |
Member
Author
Tests are in: #61172 |
KristofferC
pushed a commit
that referenced
this pull request
Mar 3, 2026
`ismalformed()` is not exported from `Base`, so we need to qualify it when calling. Detected by JET. (cherry picked from commit 1cd77b5)
KristofferC
pushed a commit
that referenced
this pull request
Mar 3, 2026
`ismalformed()` is not exported from `Base`, so we need to qualify it when calling. Detected by JET. (cherry picked from commit 1cd77b5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ismalformed()is not exported fromBase, so we need to qualify it when calling.Detected by JET.