Serialization stdlib: Replace a call to Core.memoryref with Core.memoryrefnew#61137
Merged
oscardssmith merged 2 commits intomasterfrom Mar 3, 2026
Merged
Serialization stdlib: Replace a call to Core.memoryref with Core.memoryrefnew#61137oscardssmith merged 2 commits intomasterfrom
Core.memoryref with Core.memoryrefnew#61137oscardssmith merged 2 commits intomasterfrom
Conversation
oscardssmith
approved these changes
Feb 24, 2026
Member
|
good catch. There was a name change post this code getting written. |
oscardssmith
added
bugfix
Member
|
a test could be good |
IanButterworth
added
needs tests
Member
Author
|
EDIT: I've added some tests. |
DilumAluthge
force-pushed
the
dpa/serialization-memoryref-method
branch
from
fb9ac44 to
d4cf899
Compare
DilumAluthge
force-pushed
the
dpa/serialization-memoryref-method
branch
from
d4cf899 to
8ac44d6
Compare
DilumAluthge
added
backport 1.13
Member
Author
|
The call to |
Member
Author
|
@oscardssmith Does this need to be backported to 1.11, 1.12, and 1.13? |
oscardssmith
added
backport 1.11
Member
|
Looks like this does need backports. This was missed in #54681 |
Member
Author
|
I've added some tests. @oscardssmith Can you give this another review? |
KristofferC
pushed a commit
that referenced
this pull request
Mar 5, 2026
…emoryrefnew` (#61137) The Serialization stdlib has the following function: https://github.com/JuliaLang/julia/blob/e46125f569f43e28261d1b55a0d85aacceee499a/stdlib/Serialization/src/Serialization.jl#L1445-L1450 As far as I can tell, there is no method matching `Core.memoryref(x::MemoryRef, i::Int, true::Bool)` (called on line 1448).[^1] [^1]: This issue was detected by JET. I think this should be a call to `Core.memoryrefnew(x::MemoryRef, i::Int, true::Bool)` instead, which is what this PR does. (cherry picked from commit acd9708)
KristofferC
pushed a commit
that referenced
this pull request
Mar 5, 2026
…emoryrefnew` (#61137) The Serialization stdlib has the following function: https://github.com/JuliaLang/julia/blob/e46125f569f43e28261d1b55a0d85aacceee499a/stdlib/Serialization/src/Serialization.jl#L1445-L1450 As far as I can tell, there is no method matching `Core.memoryref(x::MemoryRef, i::Int, true::Bool)` (called on line 1448).[^1] [^1]: This issue was detected by JET. I think this should be a call to `Core.memoryrefnew(x::MemoryRef, i::Int, true::Bool)` instead, which is what this PR does. (cherry picked from commit acd9708)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Serialization stdlib has the following function:
julia/stdlib/Serialization/src/Serialization.jl
Lines 1445 to 1450 in e46125f
As far as I can tell, there is no method matching
Core.memoryref(x::MemoryRef, i::Int, true::Bool)(called on line 1448).1I think this should be a call to
Core.memoryrefnew(x::MemoryRef, i::Int, true::Bool)instead, which is what this PR does.Footnotes
This issue was detected by JET. ↩