prefer returning the loaded version from pkgversion#61136
Merged
KristofferC merged 3 commits intomasterfrom Mar 5, 2026
Merged
prefer returning the loaded version from pkgversion#61136KristofferC merged 3 commits intomasterfrom
pkgversion#61136KristofferC merged 3 commits intomasterfrom
Conversation
Member
|
Could be worth a NEWS entry and perhaps a compatibility note in the docstring given that the result of an identical function call could differ across versions? |
Member
|
This is how it was intended to work #45607 Evidently regression tests are needed. |
Member
Author
Okay, because previously it never used the |
Member
|
It did in the original PR |
Member
Author
|
I broke it?? #46738. Wow. |
Member
Author
|
added a test |
KristofferC
added
backport 1.10
KristofferC
force-pushed
the
kc/pkgversion_sysimage
branch
from
ebcb497 to
05f14f2
Compare
KristofferC
added a commit
that referenced
this pull request
Mar 5, 2026
(cherry picked from commit 3ff8e7b)
KristofferC
added a commit
that referenced
this pull request
Mar 5, 2026
(cherry picked from commit 3ff8e7b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we have already loaded the package we should return the loaded version (not what would be returned if we had not loaded the package and would load it now). As a side effect, this should allow
pkgversionto work for packages that have been included in a custom sysimage.