check issimpleenoughtype for PartialStruct during issimplertype#61130
Open
adienes wants to merge 4 commits intoJuliaLang:masterfrom
Open
check issimpleenoughtype for PartialStruct during issimplertype#61130adienes wants to merge 4 commits intoJuliaLang:masterfrom
issimpleenoughtype for PartialStruct during issimplertype#61130adienes wants to merge 4 commits intoJuliaLang:masterfrom
Conversation
Member
|
This looks inaccurate of a fix. The |
Member
Author
|
let then IIUC |
issimpleenoughtype for PartialStruct during issimplertype
vtjnash
reviewed
Feb 23, 2026
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #60715
tmerge_types_slowwould checkissimpleenoughtype(u)after thePartialStructs were stripped from the types, but that path wasn't getting hit as it would early return viatmerge_fast_pathClaude assisted the analysis but the proposed fix is mine