Skip to content

codegen: Replace saveIP with InsertPointGuard#61107

Merged
Keno merged 1 commit intomasterfrom
jn/61095
Feb 21, 2026
Merged

codegen: Replace saveIP with InsertPointGuard#61107
Keno merged 1 commit intomasterfrom
jn/61095

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Feb 21, 2026

Replace manual insertion point save/restore operations with RAII-based InsertPointGuard. This ensures insertion points properly restore debug information too. With credit to abraemer for diagnosing and suggesting the fix.

Fix: #61095

Replace manual insertion point save/restore operations with RAII-based
InsertPointGuard. This ensures insertion points properly restore debug
information too. With credit to abraemer for diagnosing and suggesting
the fix.

Fix: #61095

Co-Authored-By: Adrian Braemer <adrian.braemer@tngtech.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@vtjnash vtjnash added compiler:codegen Generation of LLVM IR and native code backport 1.12 Change should be backported to release-1.12 backport 1.13 Change should be backported to release-1.13 labels Feb 21, 2026
@Keno Keno merged commit 1003b8d into master Feb 21, 2026
7 of 10 checks passed
@Keno Keno deleted the jn/61095 branch February 21, 2026 23:58
KristofferC pushed a commit that referenced this pull request Feb 25, 2026
Replace manual insertion point save/restore operations with RAII-based
InsertPointGuard. This ensures insertion points properly restore debug
information too. With credit to abraemer for diagnosing and suggesting
the fix.

Fix: #61095

Co-authored-by: Adrian Braemer <adrian.braemer@tngtech.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
(cherry picked from commit 1003b8d)
@KristofferC KristofferC mentioned this pull request Feb 25, 2026
36 tasks
KristofferC pushed a commit that referenced this pull request Mar 3, 2026
Replace manual insertion point save/restore operations with RAII-based
InsertPointGuard. This ensures insertion points properly restore debug
information too. With credit to abraemer for diagnosing and suggesting
the fix.

Fix: #61095

Co-authored-by: Adrian Braemer <adrian.braemer@tngtech.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
(cherry picked from commit 1003b8d)
@KristofferC KristofferC mentioned this pull request Mar 3, 2026
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.12 Change should be backported to release-1.12 backport 1.13 Change should be backported to release-1.13 compiler:codegen Generation of LLVM IR and native code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sometimes stacktrace shows function definition line instead of actual error line in 1.12.5

2 participants