codegen: Mark resolved const GlobalRef as method root#60945
Merged
topolarity merged 1 commit intoJuliaLang:masterfrom Feb 10, 2026
Merged
codegen: Mark resolved const GlobalRef as method root#60945topolarity merged 1 commit intoJuliaLang:masterfrom
const GlobalRef as method root#60945topolarity merged 1 commit intoJuliaLang:masterfrom
Conversation
oscardssmith
added
the
trimming
Member
|
How was the code there not segfaulting? Because I thought in this case we just removed the globalref and got the underlying object but that was rooted by the code |
Contributor
Are you referring to the MWE I posted? I think got some segfaults too while exploring, but usually it would halt before that with some other error message. |
Member
Author
|
Shockingly small impact on the sysimage: https://buildkite.com/julialang/julia-master/builds/54331#019c30cc-fd0f-4cc6-989c-ef6ae1c5376f/L2692 vs. https://buildkite.com/julialang/julia-master/builds/54334#019c3107-6984-4458-84a3-e78986f9948f/L2482 23.6 KB difference |
Member
Author
vtjnash
reviewed
Feb 7, 2026
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
This seems like it should work, since it should shove it into the global dict eventually, which we then prune during sysimage generation
vtjnash
reviewed
Feb 7, 2026
topolarity
force-pushed
the
ct/globalref-root
branch
from
b8e3f96 to
069cc99
Compare
This allows `--trim` to safely* prune bindings without dropping the root required for the generated machine code. * uninferred GlobalRefs can lead to missing bindings at runtime, but these do not directly trigger UB / crash and they are relatively rare
topolarity
force-pushed
the
ct/globalref-root
branch
from
069cc99 to
567c6ff
Compare
topolarity
added
merge me
topolarity
added
backport 1.12
KristofferC
pushed a commit
that referenced
this pull request
Feb 25, 2026
This allows `--trim` to safely* prune bindings without dropping the root required for the generated machine code. The (significantly more complex) alternative will be to examine the bindings (back)edges during `--trim` serialization and reconstruct the relevant binding dependency edges at that time but that does not seem worth it compared to the 23.6 KB overhead in the sysimage to track these roots explicitly. Resolves #60846. \* As a caveat, uninferred GlobalRefs can lead to missing bindings at runtime, but this is out-of-scope for --trim. (cherry picked from commit 484e7b1)
KristofferC
pushed a commit
that referenced
this pull request
Mar 3, 2026
This allows `--trim` to safely* prune bindings without dropping the root required for the generated machine code. The (significantly more complex) alternative will be to examine the bindings (back)edges during `--trim` serialization and reconstruct the relevant binding dependency edges at that time but that does not seem worth it compared to the 23.6 KB overhead in the sysimage to track these roots explicitly. Resolves #60846. \* As a caveat, uninferred GlobalRefs can lead to missing bindings at runtime, but this is out-of-scope for --trim. (cherry picked from commit 484e7b1)
56 tasks
KristofferC
removed
the
backport 1.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
--trimto safely* prune bindings without dropping the root required for the generated machine code.Opening this PR with a "simple" solution to get numbers / opinions on the overhead of these extra roots.
The (significantly more complex) alternative will be to examine the bindings (back)edges during
--trimserialization and reconstruct the relevant binding dependency edges at that time. I'll update this PR in-place with that solution if it seems like the right direction to go instead.Resolves #60846.
* As a caveat, uninferred GlobalRefs can lead to missing bindings at runtime, but this is out-of-scope for --trim.