Compiler: fix typo in can_propagate_conditional #60902
Merged
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function was checking `rt.thentype` twice instead of checking both `rt.thentype` and `rt.elsetype`. This caused incorrect type narrowing when conditional types were propagated through wrapper functions. Fixes #60883 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Keno
added
bugfix
KristofferC
pushed a commit
that referenced
this pull request
Feb 4, 2026
The function was checking `rt.thentype` twice instead of checking both `rt.thentype` and `rt.elsetype`. This caused incorrect type narrowing when conditional types were propagated through wrapper functions. Fixes #60883. Completely done by Claude. Co-authored-by: Keno Fischer <[email protected]> Co-authored-by: Claude Opus 4.5 <[email protected]> (cherry picked from commit 922aa53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was checking
rt.thentypetwice instead of checking bothrt.thentypeandrt.elsetype. This caused incorrect type narrowing when conditional types were propagated through wrapper functions.Fixes #60883. Completely done by Claude.