REPL: fix highlighting of the region and of enclosing parentheses#60893
Merged
KristofferC merged 2 commits intoJuliaLang:masterfrom Mar 17, 2026
Merged
REPL: fix highlighting of the region and of enclosing parentheses#60893KristofferC merged 2 commits intoJuliaLang:masterfrom
KristofferC merged 2 commits intoJuliaLang:masterfrom
Conversation
Contributor
Author
|
The highlighting of enclosing parentheses also has a problem: When the cursor is on a closing parenthesis, then the corresponding opening parenthesis is highlighted, but not the other way around. This is now fixed in the second commit. |
matthias314
changed the title
Member
|
I confirmed the bug and that this PR fixes it. Ideally it would have a test but since it can be a bit annoying to write for these interactive tools I think it is ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #60762
In the syntax highlighting introduced in #59778 for Julia 1.13, the region highlighting is off by 1. This PR fixed this. I believe that the region highlighting is now as in 1.12, up to the added colors.
@KristofferC Could you have a look at it?