Skip to content

Artifacts stdlib: Add TOML and Pkg as test dependencies#60891

Merged
DilumAluthge merged 2 commits intomasterfrom
dpa/artifacts-tests
Feb 1, 2026
Merged

Artifacts stdlib: Add TOML and Pkg as test dependencies#60891
DilumAluthge merged 2 commits intomasterfrom
dpa/artifacts-tests

Conversation

@DilumAluthge
Copy link
Member

Because TOML is used in the tests:

Noticed in PkgEval (log)

@DilumAluthge DilumAluthge requested a review from giordano January 31, 2026 23:50
@DilumAluthge DilumAluthge marked this pull request as ready for review January 31, 2026 23:50
@DilumAluthge DilumAluthge marked this pull request as draft January 31, 2026 23:51
@DilumAluthge DilumAluthge removed the request for review from giordano January 31, 2026 23:51
@DilumAluthge
Copy link
Member Author

@nanosoldier runtests(["Artifacts"], configuration = (goal=:test,), vs_configuration = (goal=:test,))

@DilumAluthge
Copy link
Member Author

I think we also need Pkg:

(@v1.14) pkg> test Artifacts
     Testing Artifacts
      Status `/private/var/folders/6_/74jkq2z92hzd17_6c7pf70100000gp/T/jl_5OzWKt/Project.toml`
  [56f22d72] Artifacts v1.11.0
  [fa267f1f] TOML v1.0.3
  [8dfed614] Test v1.11.0
      Status `/private/var/folders/6_/74jkq2z92hzd17_6c7pf70100000gp/T/jl_5OzWKt/Manifest.toml`
  [56f22d72] Artifacts v1.11.0
  [2a0f44e3] Base64 v1.11.0
  [ade2ca70] Dates v1.11.0
  [b77e0a4c] InteractiveUtils v1.11.0
  [ac6e5ff7] JuliaSyntaxHighlighting v1.13.0
  [56ddb016] Logging v1.11.0
  [d6f4376e] Markdown v1.11.0
  [de0858da] Printf v1.11.0
  [9a3f8284] Random v1.11.0
  [ea8e919c] SHA v1.0.0
  [9e88b42a] Serialization v1.11.0
  [f489334b] StyledStrings v1.13.0
  [fa267f1f] TOML v1.0.3
  [8dfed614] Test v1.11.0
  [4ec0a83e] Unicode v1.11.0
     Testing Running tests...
ERROR: LoadError: ArgumentError: Package Pkg not found in current path.
Stacktrace:

@DilumAluthge DilumAluthge changed the title Artifacts stdlib: Add TOML as a test dependency Artifacts stdlib: Add TOML and Pkg as test dependencies Feb 1, 2026
@DilumAluthge
Copy link
Member Author

@nanosoldier runtests(["Artifacts"], configuration = (goal=:test,), vs_configuration = (goal=:test,))

@DilumAluthge DilumAluthge marked this pull request as ready for review February 1, 2026 00:25
@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Feb 1, 2026
@DilumAluthge
Copy link
Member Author

There are other problems (namely, that PkgEval doesn't run with --depwarn=error, but this at least fixes the test deps.

@DilumAluthge DilumAluthge added test This change adds or pertains to unit tests stdlib Julia's standard library backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 backport 1.12 Change should be backported to release-1.12 backport 1.13 Change should be backported to release-1.13 labels Feb 1, 2026
@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - no new issues were detected.
The full report is available.

Report summary

✖ Packages that failed

1 packages failed on the previous version too.

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - no new issues were detected.
The full report is available.

Report summary

✖ Packages that failed

1 packages failed on the previous version too.

@inkydragon
Copy link
Member

PkgEval find this:

┌ Warning: using Pkg instead of using LazyArtifacts is deprecated
│   caller = ip:0x0
└ @ Core :-1
 Downloading artifact: socrates

@artifact_str install errors: Test Failed at /opt/julia/share/julia/stdlib/v1.14/Artifacts/test/runtests.jl:250
  Expression: startswith("using Pkg instead of using LazyArtifacts is deprecated", e.msg)
   Evaluated: startswith("using Pkg instead of using LazyArtifacts is deprecated", "this @artifact_str macro invocation should have failed!")
  Stacktrace:

NOTE: This test works fine in CI system.
Maybe there are some different with test flags.

@nsajko nsajko added the duplicate Indicates similar issues or pull requests label Feb 1, 2026
@nsajko
Copy link
Member

nsajko commented Feb 1, 2026

duplicates the earlier PR #60872

@DilumAluthge DilumAluthge merged commit ed71c10 into master Feb 1, 2026
19 checks passed
@DilumAluthge DilumAluthge deleted the dpa/artifacts-tests branch February 1, 2026 21:30
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Feb 1, 2026
@DilumAluthge
Copy link
Member Author

duplicates the earlier PR #60872

Ah, sorry I didn't see this until after I merged.

@DilumAluthge
Copy link
Member Author

PkgEval find this:

┌ Warning: using Pkg instead of using LazyArtifacts is deprecated
│   caller = ip:0x0
└ @ Core :-1
 Downloading artifact: socrates

@artifact_str install errors: Test Failed at /opt/julia/share/julia/stdlib/v1.14/Artifacts/test/runtests.jl:250
  Expression: startswith("using Pkg instead of using LazyArtifacts is deprecated", e.msg)
   Evaluated: startswith("using Pkg instead of using LazyArtifacts is deprecated", "this @artifact_str macro invocation should have failed!")
  Stacktrace:

NOTE: This test works fine in CI system. Maybe there are some different with test flags.

Yeah, the issue is --depwarn, which is different in PkgEval vs Base Julia Buildkite. I'm working on this in #60892.

@KristofferC KristofferC removed the backport 1.13 Change should be backported to release-1.13 label Feb 4, 2026
@KristofferC KristofferC mentioned this pull request Feb 20, 2026
45 tasks
@KristofferC KristofferC mentioned this pull request Feb 25, 2026
36 tasks
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.11 Change should be backported to release-1.11 backport 1.12 Change should be backported to release-1.12 duplicate Indicates similar issues or pull requests stdlib Julia's standard library test This change adds or pertains to unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants