Artifacts stdlib: Add TOML and Pkg as test dependencies#60891
Artifacts stdlib: Add TOML and Pkg as test dependencies#60891DilumAluthge merged 2 commits intomasterfrom
TOML and Pkg as test dependencies#60891Conversation
|
@nanosoldier |
|
I think we also need Pkg: |
TOML as a test dependencyTOML and Pkg as test dependencies
|
@nanosoldier |
|
There are other problems (namely, that PkgEval doesn't run with |
|
The package evaluation job you requested has completed - no new issues were detected. Report summary✖ Packages that failed1 packages failed on the previous version too. |
|
The package evaluation job you requested has completed - no new issues were detected. Report summary✖ Packages that failed1 packages failed on the previous version too. |
|
PkgEval find this: NOTE: This test works fine in CI system. |
|
duplicates the earlier PR #60872 |
Ah, sorry I didn't see this until after I merged. |
Yeah, the issue is |
Because `TOML` is used in the tests: https://github.com/JuliaLang/julia/blob/b51d41ac753f46a3529f47fe3c6638895cf97c6d/stdlib/Artifacts/test/runtests.jl#L6-L6 Noticed in PkgEval ([log](https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/a6a3237_vs_63406df/Artifacts.primary.log)) (cherry picked from commit ed71c10)
Because `TOML` is used in the tests: https://github.com/JuliaLang/julia/blob/b51d41ac753f46a3529f47fe3c6638895cf97c6d/stdlib/Artifacts/test/runtests.jl#L6-L6 Noticed in PkgEval ([log](https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/a6a3237_vs_63406df/Artifacts.primary.log)) (cherry picked from commit ed71c10)
Because `TOML` is used in the tests: https://github.com/JuliaLang/julia/blob/b51d41ac753f46a3529f47fe3c6638895cf97c6d/stdlib/Artifacts/test/runtests.jl#L6-L6 Noticed in PkgEval ([log](https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/a6a3237_vs_63406df/Artifacts.primary.log)) (cherry picked from commit ed71c10)
Because
TOMLis used in the tests:julia/stdlib/Artifacts/test/runtests.jl
Line 6 in b51d41a
Noticed in PkgEval (log)