Skip to content

merge the three methods of error into a single method #60878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanButterworth merged 3 commits into from
Feb 2, 2026
Merged

merge the three methods of error into a single method #60878

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7593fc3
merge the three methods of `error` into a single method
nsajko Jan 29, 2026
ca2726d
add back comment
nsajko Jan 29, 2026
923a47f
Merge branch 'master' into error-no-max_methods-special-casing
nsajko Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions base/error.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,22 +27,17 @@ throw

## native julia error handling ##

# This is `Experimental.@max_methods 2 function error end`, which is not available at this point in bootstrap.
# NOTE It is important to always be able to infer the return type of `error` as `Union{}`,
# but there's a hitch when a package globally sets `@max_methods 1` and it causes inference
# for `error(::Any)` to fail (JuliaLang/julia#54029).
# This definition site `@max_methods 2` setting overrides any global `@max_methods 1` settings
# on package side, guaranteeing that return type inference on `error` is successful always.
# see issue (JuliaLang/julia#54029). Ensure that method counts are small enough with
# respect to the `max_methods` value of the function.
function error end
typeof(error).name.max_methods = UInt8(2)

"""
error(message::AbstractString)

Raise an `ErrorException` with the given message.
"""
error(s::AbstractString) = throw(ErrorException(s))
error() = throw(ErrorException(""))
error(::AbstractString)

"""
error(msg...)
Expand All @@ -51,7 +46,14 @@ Raise an `ErrorException` with a message constructed by `string(msg...)`.
"""
function error(s::Vararg{Any,N}) where {N}
@noinline
throw(ErrorException(Main.Base.string(s...)))
exc = if s === ()
ErrorException("")
elseif s isa Tuple{AbstractString}
ErrorException(s...)
else
ErrorException(Main.Base.string(s...))
end
throw(exc)
end

"""
Expand Down