add missing root #6085
Merged
add missing root #6085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are a saint among men. |
|
Out of curiosity, is there any particular test you ran to see if this fixes the intermittent bug? |
|
I'm afraid not. It was a bit more easy to trigger on the inc branch because the gc is running more often. I happened to hit a build (running linalg1-2, not on my machine though) where the bug was a bit stable and easier to track down. There is no definitive proof that it is gone, I guess we'll have to wait & see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this while rebasing #5227. It seems to fix the "no method error length(" on at least my build. It's hard to tell because it is quite random. Looks like this should be rooted anyway.