Make jl_reinit_foreign_type idempotent even with asserts
#60827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, if it is called twice (e.g. because precompilation is disabled) with identical arguments, then this should not trigger an assertion.
fingolfin
added
backport 1.10
Contributor
|
I can confirm that this patch gets rid of the crashes from oscar-system/GAP.jl#1314 (comment) (i.e. |
DilumAluthge
pushed a commit
that referenced
this pull request
Jan 27, 2026
That is, if it is called twice (e.g. because precompilation is disabled) with identical arguments, then this should not trigger an assertion. This should resolve oscar-system/GAP.jl#1314 (cherry picked from commit 1708d99)
71 tasks
DilumAluthge
pushed a commit
that referenced
this pull request
Jan 28, 2026
That is, if it is called twice (e.g. because precompilation is disabled) with identical arguments, then this should not trigger an assertion. This should resolve oscar-system/GAP.jl#1314 (cherry picked from commit 1708d99)
DilumAluthge
pushed a commit
that referenced
this pull request
Jan 29, 2026
That is, if it is called twice (e.g. because precompilation is disabled) with identical arguments, then this should not trigger an assertion. This should resolve oscar-system/GAP.jl#1314 (cherry picked from commit 1708d99)
KristofferC
pushed a commit
that referenced
this pull request
Feb 2, 2026
That is, if it is called twice (e.g. because precompilation is disabled) with identical arguments, then this should not trigger an assertion. This should resolve oscar-system/GAP.jl#1314 (cherry picked from commit 1708d99)
KristofferC
removed
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, if it is called twice (e.g. because precompilation is disabled) with identical arguments, then this should not trigger an assertion.
This should resolve oscar-system/GAP.jl#1314