Skip to content

Conversation

@wsmoses
Copy link
Member

@wsmoses wsmoses commented Jan 14, 2026

No description provided.

@wsmoses wsmoses requested a review from vchuravy January 14, 2026 15:19
@wsmoses
Copy link
Member Author

wsmoses commented Jan 14, 2026

backport of exporting data in #58423

@oscardssmith oscardssmith added compiler:plugins backport 1.11 Change should be backported to release-1.11 labels Jan 14, 2026
@gbaraldi gbaraldi added the merge me PR is reviewed. Merge when all tests are passing label Jan 14, 2026
@fingolfin
Copy link
Member

Didn't we just recently discuss that merging directly into a release branch without a backports-release-x.y is problematic because no NanoSoldier is run and regressions can creep in undetected?

@fingolfin fingolfin removed the merge me PR is reviewed. Merge when all tests are passing label Jan 14, 2026
@wsmoses
Copy link
Member Author

wsmoses commented Jan 14, 2026

There's no backports branch atm and had to make a PR somewhere

@gbaraldi
Copy link
Member

Billy can you target a back ports branch here? If it doesn't exist create one

@wsmoses
Copy link
Member Author

wsmoses commented Jan 14, 2026

Yeah can do, just make another pr/branch off the current release and call it backports?

@DilumAluthge
Copy link
Member

Retargeting to target the backports branch.

@DilumAluthge DilumAluthge changed the base branch from release-1.11 to backports-release-1.11 January 14, 2026 20:32
@DilumAluthge
Copy link
Member

Alright, looks goods - now it's targeting the current branch.

@wsmoses wsmoses added the merge me PR is reviewed. Merge when all tests are passing label Jan 14, 2026
@DilumAluthge DilumAluthge mentioned this pull request Jan 14, 2026
57 tasks
@DilumAluthge
Copy link
Member

DilumAluthge commented Jan 14, 2026

I'm seeing a failure two times in a row in the Windows tests, in the threads tests. I've triggered another retry. Any chance the failure could be caused by this PR?

@wsmoses
Copy link
Member Author

wsmoses commented Jan 14, 2026

I don't think so, this Pr shouldn't impact any existing code as it just adds a new symbol

@DilumAluthge
Copy link
Member

Let's just merge into backports then, and work on fixing the CI in the backports PR (#60692).

@DilumAluthge DilumAluthge merged commit 47abd35 into backports-release-1.11 Jan 14, 2026
10 of 12 checks passed
@DilumAluthge DilumAluthge deleted the wm/111gv branch January 14, 2026 22:53
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 14, 2026
@vchuravy
Copy link
Member

@wsmoses in the future please add a description to your PR (and perhaps open one PR first instead of three backport PRs at once).

Root cause analysis is here JuliaGPU/GPUCompiler.jl#753

@github-actions github-actions bot removed the backport 1.11 Change should be backported to release-1.11 label Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants