-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
1.11: add getter for global variable pointer matching jlvalue #60684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
backport of exporting data in #58423 |
|
Didn't we just recently discuss that merging directly into a release branch without a backports-release-x.y is problematic because no NanoSoldier is run and regressions can creep in undetected? |
|
There's no backports branch atm and had to make a PR somewhere |
|
Billy can you target a back ports branch here? If it doesn't exist create one |
|
Yeah can do, just make another pr/branch off the current release and call it backports? |
|
Retargeting to target the backports branch. |
|
Alright, looks goods - now it's targeting the current branch. |
|
I'm seeing a failure two times in a row in the Windows tests, in the |
|
I don't think so, this Pr shouldn't impact any existing code as it just adds a new symbol |
|
Let's just merge into backports then, and work on fixing the CI in the backports PR (#60692). |
|
@wsmoses in the future please add a description to your PR (and perhaps open one PR first instead of three backport PRs at once). Root cause analysis is here JuliaGPU/GPUCompiler.jl#753 |
No description provided.