Skip to content

Don't set the owner of the string needlessly. #60601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DilumAluthge merged 2 commits into from
Jan 14, 2026
Merged

Don't set the owner of the string needlessly. #60601

DilumAluthge merged 2 commits into from
Jan 14, 2026

Conversation

@gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Jan 8, 2026 •
edited
Loading

This might cause double frees/use after frees.

Found on the mimalloc PR

@gbaraldi gbaraldi requested a review from d-netto as a code owner January 8, 2026 13:45
@vtjnash vtjnash added backport 1.12 Change should be backported to release-1.12 backport 1.13 Change should be backported to release-1.13 backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 and removed backport 1.10 Change should be backported to the 1.10 release labels Jan 8, 2026
@oscardssmith oscardssmith added strings "Strings!" bugfix This change fixes an existing bug labels Jan 8, 2026
This was referenced Jan 9, 2026
Merged
Merged
@gbaraldi gbaraldi added the merge me PR is reviewed. Merge when all tests are passing label Jan 14, 2026
@DilumAluthge DilumAluthge changed the title Don´t set the owner of the string needlessly. Don't set the owner of the string needlessly. Jan 14, 2026
@DilumAluthge DilumAluthge merged commit 06def89 into master Jan 14, 2026
10 checks passed
@DilumAluthge DilumAluthge deleted the gb/memoryfun branch January 14, 2026 20:42
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 14, 2026
@DilumAluthge DilumAluthge mentioned this pull request Jan 14, 2026
Merged
57 tasks
DilumAluthge pushed a commit that referenced this pull request Jan 15, 2026
@gbaraldi @DilumAluthge
Don't set the owner of the string needlessly. (#60601)
e1e955a 
This might cause double frees/use after frees.

Found on the mimalloc PR

(cherry picked from commit 06def89)
KristofferC pushed a commit that referenced this pull request Jan 26, 2026
@gbaraldi @KristofferC
Don't set the owner of the string needlessly. (#60601)
8c85653 
This might cause double frees/use after frees.

Found on the mimalloc PR

(cherry picked from commit 06def89)
@KristofferC KristofferC removed backport 1.12 Change should be backported to release-1.12 backport 1.13 Change should be backported to release-1.13 labels Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash approved these changes

@d-netto d-netto Awaiting requested review from d-netto d-netto is a code owner

@oscardssmith oscardssmith Awaiting requested review from oscardssmith

Assignees

No one assigned

Labels

backport 1.11 Change should be backported to release-1.11 bugfix This change fixes an existing bug strings "Strings!"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gbaraldi @vtjnash @KristofferC @DilumAluthge @oscardssmith