Fix JET warning in artifact_meta
#60507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unpack_platform might return nothing in case of an error.
fingolfin
added
backport 1.12
topolarity
approved these changes
Dec 29, 2025
KristofferC
pushed a commit
that referenced
this pull request
Jan 7, 2026
`unpack_platform` might return nothing in case of an error. Together with PR #60506 and my previous changes, when applied to release-1.12, the JET report for GAP.jl is now free of reports. Well, if I filter out certain "unavoidable issues": ```julia using Revise, JET, AbstractAlgebra, GAP struct AnyFrameMethod <: ReportMatcher m::Union{Function,Method,Symbol} end function JET.match_report(matcher::AnyFrameMethod, @nospecialize(report::JET.InferenceErrorReport)) # check all VirtualFrames in the VirtualStackTrace for a match to the specified method m = matcher.m if m isa Symbol return any(vf -> vf.linfo.def.name === m, report.vst) elseif m isa Method return any(vf -> vf.linfo.def === m, report.vst) else # if m isa Function return any(vf -> vf.linfo.def in methods(m), report.vst) end end report_package(GAP; ignored_modules=[AnyFrameMethod(:is_loaded_directly)]) ``` (cherry picked from commit 8123a5c)
KristofferC
pushed a commit
that referenced
this pull request
Jan 8, 2026
`unpack_platform` might return nothing in case of an error. Together with PR #60506 and my previous changes, when applied to release-1.12, the JET report for GAP.jl is now free of reports. Well, if I filter out certain "unavoidable issues": ```julia using Revise, JET, AbstractAlgebra, GAP struct AnyFrameMethod <: ReportMatcher m::Union{Function,Method,Symbol} end function JET.match_report(matcher::AnyFrameMethod, @nospecialize(report::JET.InferenceErrorReport)) # check all VirtualFrames in the VirtualStackTrace for a match to the specified method m = matcher.m if m isa Symbol return any(vf -> vf.linfo.def.name === m, report.vst) elseif m isa Method return any(vf -> vf.linfo.def === m, report.vst) else # if m isa Function return any(vf -> vf.linfo.def in methods(m), report.vst) end end report_package(GAP; ignored_modules=[AnyFrameMethod(:is_loaded_directly)]) ``` (cherry picked from commit 8123a5c)
KristofferC
pushed a commit
that referenced
this pull request
Jan 9, 2026
`unpack_platform` might return nothing in case of an error. Together with PR #60506 and my previous changes, when applied to release-1.12, the JET report for GAP.jl is now free of reports. Well, if I filter out certain "unavoidable issues": ```julia using Revise, JET, AbstractAlgebra, GAP struct AnyFrameMethod <: ReportMatcher m::Union{Function,Method,Symbol} end function JET.match_report(matcher::AnyFrameMethod, @nospecialize(report::JET.InferenceErrorReport)) # check all VirtualFrames in the VirtualStackTrace for a match to the specified method m = matcher.m if m isa Symbol return any(vf -> vf.linfo.def.name === m, report.vst) elseif m isa Method return any(vf -> vf.linfo.def === m, report.vst) else # if m isa Function return any(vf -> vf.linfo.def in methods(m), report.vst) end end report_package(GAP; ignored_modules=[AnyFrameMethod(:is_loaded_directly)]) ``` (cherry picked from commit 8123a5c)
DilumAluthge
pushed a commit
that referenced
this pull request
Jan 9, 2026
`unpack_platform` might return nothing in case of an error. Together with PR #60506 and my previous changes, when applied to release-1.12, the JET report for GAP.jl is now free of reports. Well, if I filter out certain "unavoidable issues": ```julia using Revise, JET, AbstractAlgebra, GAP struct AnyFrameMethod <: ReportMatcher m::Union{Function,Method,Symbol} end function JET.match_report(matcher::AnyFrameMethod, @nospecialize(report::JET.InferenceErrorReport)) # check all VirtualFrames in the VirtualStackTrace for a match to the specified method m = matcher.m if m isa Symbol return any(vf -> vf.linfo.def.name === m, report.vst) elseif m isa Method return any(vf -> vf.linfo.def === m, report.vst) else # if m isa Function return any(vf -> vf.linfo.def in methods(m), report.vst) end end report_package(GAP; ignored_modules=[AnyFrameMethod(:is_loaded_directly)]) ``` (cherry picked from commit 8123a5c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unpack_platformmight return nothing in case of an error.Together with PR #60506 and my previous changes, when applied to release-1.12, the JET report for GAP.jl is now free of reports. Well, if I filter out certain "unavoidable issues":
CC @lgoettgens