Skip to content

Fix @allocated 1 .+ 1 #60494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
N5N3 merged 2 commits into from
Dec 29, 2025
Merged

Fix @allocated 1 .+ 1 #60494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9d3f47
Fix `@allocated 1 .+ 1`
N5N3 Dec 28, 2025
116cab1
Update base/timing.jl
N5N3 Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions base/timing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,14 @@ function is_simply_call(@nospecialize ex)
Meta.isexpr(a, :..., 1) && is_simple_atom(a.args[1]) && continue
return false
end
# Ensure Expr(:call, .+, ...) get wrapped
if ex.args[1] isa Symbol
sa = String(ex.args[1]::Symbol)
startswith(sa, ".") &&
!endswith(sa, ".") &&
isoperator(Symbol(sa[2:end])) &&
return false
end
return true
end

Expand Down
3 changes: 3 additions & 0 deletions test/misc.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1560,6 +1560,9 @@ end
@allocated _x = 1+2
@test _x === 3

# test `@allocated` works for dotted operations
@test (@allocated 1 .+ 1) == 0

n, m = 10, 20
X = rand(n, m)
treshape59278(X, n, m)
Expand Down