REPL: fix completion overwriting input after cursor #60472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When completing keyword arguments with the cursor in the middle of an identifier (e.g., `verb|true` in `versioninfo(; verb|true)`), the completion range was incorrectly set to cover the entire identifier instead of just the portion before the cursor. This caused the completion to overwrite the text after the cursor. The fix intersects the character range with `1:pos` to limit the replacement range to only the text before the cursor, matching the behavior used for regular symbol completion. Fixes JuliaLang#60444 Co-authored-by: Claude <[email protected]>
IanButterworth
added
REPL
Member
|
I believe this fixes another related bug I ran into yesterday: currently pressing TAB at julia> f("/path/to/something|)[N]deletes the rest of the line after |
Apply the same fix as the keyword argument completion to Dict key completion and string path completion. These also had the issue where completing with the cursor in the middle of text would overwrite content after the cursor. The fix intersects the completion range with `1:pos` to limit replacements to only the text before the cursor. Co-authored-by: Claude <[email protected]>
IanButterworth
force-pushed
the
ib/repl_60444
branch
from
d32e0a1 to
ffbf16f
Compare
IanButterworth
changed the title
giordano
approved these changes
Dec 25, 2025
giordano
added
bugfix
KristofferC
pushed a commit
that referenced
this pull request
Jan 7, 2026
(cherry picked from commit b6337dd)
KristofferC
pushed a commit
that referenced
this pull request
Jan 8, 2026
(cherry picked from commit b6337dd)
KristofferC
pushed a commit
that referenced
this pull request
Jan 9, 2026
(cherry picked from commit b6337dd)
DilumAluthge
pushed a commit
that referenced
this pull request
Jan 9, 2026
(cherry picked from commit b6337dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few completion overwriting bugs. See commit messages for details.
Fixes #60444