Use POSIX shell instead of Bash in escape_json.sh #60295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`/bin/bash` doesn't exist everywhere (e.g., FreeBSD), while `/bin/sh` should. Luckily the Bashisms that were used are easily replaced with a couple of `sed`s, so the changes are minimal.
vtjnash
approved these changes
Dec 2, 2025
KristofferC
pushed a commit
that referenced
this pull request
Dec 4, 2025
(cherry picked from commit af36919)
KristofferC
pushed a commit
that referenced
this pull request
Dec 4, 2025
(cherry picked from commit af36919)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/bin/bashdoesn't exist everywhere (e.g., FreeBSD), while/bin/shshould. Luckily the Bashisms that were used are easily replaced with a couple ofseds, so the changes are minimal.Marking for backport to 1.13 since this was introduced before branching and it fixes annoying "no such file or directory" messages observed while building on FreeBSD.