Fix embedding with MSVC #60142
Merged
Fix embedding with MSVC #60142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barche
force-pushed
the
fix-msvc-embed
branch
from
5ce2f6a to
c96f45a
Compare
KristofferC
pushed a commit
that referenced
this pull request
Feb 6, 2026
The use of `__attribute__` in headers causes compile errors on MSVC, this PR removes these when compiling a program that includes Julia headers with MSVC. The `DECLSPEC_IMPORT` macro is also defined by default on MSVC, so it is deactivated when in MSVC. See the [log starting here](https://github.com/JuliaInterop/libcxxwrap-julia/actions/runs/19379560768/job/55455166299#step:4:60) for an example of the errors. (cherry picked from commit 89243d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
__attribute__in headers causes compile errors on MSVC, this PR removes these when compiling a program that includes Julia headers with MSVC.The
DECLSPEC_IMPORTmacro is also defined by default on MSVC, so it is deactivated when in MSVC.See the log starting here for an example of the errors.