Skip to content

Conversation

@JamesWrigley
Copy link
Member

This prevents invalidations of isready() from loading Distributed on 1.12:

 inserting isready(pool::Distributed.WorkerPool) @ Distributed ~/.julia/juliaup/julia-1.12.1+0.x64.linux.gnu/share/julia/stdlib/v1.12/Distributed/src/workerpool.jl:168 invalidated:
   mt_backedges: 1: signature Tuple{typeof(isready), Any} triggered MethodInstance for (::Compiler.var"#evalargs#abstract_eval_nonlinearized_foreigncall_name##0"{Expr, Compiler.StatementState, Compiler.Future{Compiler.CallMeta}, Vector{Any}, Int64})(::Compiler.AbstractInterpreter, ::Compiler.InferenceState) (0 children)
                 2: signature Tuple{typeof(isready), Any} triggered MethodInstance for (::Compiler.var"#evalargs#abstract_eval_nonlinearized_foreigncall_name##0"{Expr, Compiler.StatementState, Compiler.Future{Compiler.CallMeta}, Vector{Any}, Int64})(::Compiler.NativeInterpreter, ::Compiler.InferenceState) (0 children)
                 3: signature Tuple{typeof(isready), Any} triggered MethodInstance for (::Compiler.var"#evalargs#abstract_eval_nonlinearized_foreigncall_name##0"{Expr, Compiler.StatementState, Compiler.Future{Compiler.CallMeta}, Vector{Any}, Int64})(::Compiler.AbstractInterpreter, ::Compiler.InferenceState) (249 children)

I think ideally it wouldn't use a closure at all, but I'm not familiar enough with the code to refactor it that much. I'm making the PR against the release-1.12 branch because this function is deleted entirely on master by #59165.

…all_name`

This prevents invalidations of `isready()`.
@KristofferC KristofferC changed the base branch from release-1.12 to backports-release-1.12 October 21, 2025 10:34
@JamesWrigley
Copy link
Member Author

This is well beyond my comfort zone so I can't say for sure, but I think the build/test failures are unrelated. I had a look at the return types of functions that assign to ai and res and they all seem to be Future.

@vtjnash vtjnash merged commit 08b0e69 into JuliaLang:backports-release-1.12 Oct 24, 2025
5 of 8 checks passed
@KristofferC KristofferC added the backport 1.12 Change should be backported to release-1.12 label Oct 24, 2025
@vtjnash vtjnash mentioned this pull request Oct 24, 2025
18 tasks
@JamesWrigley JamesWrigley deleted the compiler-invalidations branch October 24, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.12 Change should be backported to release-1.12

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants