Skip to content

Conversation

@staticfloat
Copy link
Member

@staticfloat staticfloat commented Oct 5, 2025

This gets us fixes for Windows 0, some fixes for setting thread numbers for MKL and NVPL, and fixes for building from source and not using BinaryBuilder-built binaries on Windows.

Fixes #59650

This gets us fixes for Windows [0], some fixes for setting thread numbers
for MKL and NVPL, and fixes for building from source and not using
BinaryBuilder-built binaries on Windows.

[0]: #59650 (comment)
@staticfloat staticfloat requested a review from giordano as a code owner October 5, 2025 22:25
@giordano giordano added building Build system, or building Julia or its dependencies linear algebra Linear algebra external dependencies Involves LLVM, OpenBLAS, or other linked libraries merge me PR is reviewed. Merge when all tests are passing JLLs labels Oct 5, 2025
@giordano giordano linked an issue Oct 5, 2025 that may be closed by this pull request
@DilumAluthge
Copy link
Member

Backportable to 1.12?

@staticfloat
Copy link
Member Author

Yes, it should be fully compatible.

@DilumAluthge DilumAluthge added the backport 1.12 Change should be backported to release-1.12 label Oct 5, 2025
@DilumAluthge
Copy link
Member

Does this close #59650?

@giordano
Copy link
Member

giordano commented Oct 5, 2025

Does this close #59650?

Yes

Screenshot_20251006-010245

@IanButterworth IanButterworth merged commit b76c189 into master Oct 6, 2025
16 checks passed
@IanButterworth IanButterworth deleted the sf/lbt-v5.15.0 branch October 6, 2025 01:23
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 6, 2025
@KristofferC KristofferC mentioned this pull request Oct 6, 2025
47 tasks
KristofferC pushed a commit that referenced this pull request Oct 10, 2025
KristofferC pushed a commit that referenced this pull request Oct 12, 2025
KristofferC pushed a commit that referenced this pull request Oct 14, 2025
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs linear algebra Linear algebra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Profile test seems to sporadically hang on Window x86-64

5 participants