precompile: fix a myriad of concurrency and cache handling mistakes #59670
+192
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The LOADING_CACHE PR failed to acquire the lock in many places it was new made mandatory. * The stale_cache_key did not include many relevant parameters. * The `isprecompiled` implementation failed to account for the preferred stdlib logic of loading. * The `isprecompiled` cache failed to account for either newly compiled packages or other changes to the file system. * After parallel precompile noticed a package fails, it would retry with serial precompile, which was very pointless. * Semaphore could be <= 0, leading to deadlock.
vtjnash
force-pushed
the
jn/precompilation-quality
branch
from
13e4fd0 to
773987b
Compare
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2025
…59670) * The PR for LOADING_CACHE failed to acquire the lock in many places it was newly made mandatory. * The stale_cache_key did not include many relevant parameters. * The `isprecompiled` implementation failed to account for the preferred stdlib logic of loading. * The `isprecompiled` cache failed to account for either newly compiled packages or other changes to the file system. * After parallel precompile noticed a package fails, it would retry with serial precompile, which was very pointless. * Semaphore could be <= 0, leading to deadlock. * After parallel precompile noticed a failure, it would crash, instead of allowing the program to continue on to load the package normally. We had tests for this, but they had gotten removed. (cherry picked from commit f362f47)
|
It looks like backporting this to 1.12 requires backporting #59212 too. |
KristofferC
pushed a commit
that referenced
this pull request
Oct 12, 2025
…59670) * The PR for LOADING_CACHE failed to acquire the lock in many places it was newly made mandatory. * The stale_cache_key did not include many relevant parameters. * The `isprecompiled` implementation failed to account for the preferred stdlib logic of loading. * The `isprecompiled` cache failed to account for either newly compiled packages or other changes to the file system. * After parallel precompile noticed a package fails, it would retry with serial precompile, which was very pointless. * Semaphore could be <= 0, leading to deadlock. * After parallel precompile noticed a failure, it would crash, instead of allowing the program to continue on to load the package normally. We had tests for this, but they had gotten removed. (cherry picked from commit f362f47)
KristofferC
pushed a commit
that referenced
this pull request
Oct 12, 2025
…59670) * The PR for LOADING_CACHE failed to acquire the lock in many places it was newly made mandatory. * The stale_cache_key did not include many relevant parameters. * The `isprecompiled` implementation failed to account for the preferred stdlib logic of loading. * The `isprecompiled` cache failed to account for either newly compiled packages or other changes to the file system. * After parallel precompile noticed a package fails, it would retry with serial precompile, which was very pointless. * Semaphore could be <= 0, leading to deadlock. * After parallel precompile noticed a failure, it would crash, instead of allowing the program to continue on to load the package normally. We had tests for this, but they had gotten removed. (cherry picked from commit f362f47)
KristofferC
pushed a commit
that referenced
this pull request
Oct 15, 2025
…59670) * The PR for LOADING_CACHE failed to acquire the lock in many places it was newly made mandatory. * The stale_cache_key did not include many relevant parameters. * The `isprecompiled` implementation failed to account for the preferred stdlib logic of loading. * The `isprecompiled` cache failed to account for either newly compiled packages or other changes to the file system. * After parallel precompile noticed a package fails, it would retry with serial precompile, which was very pointless. * Semaphore could be <= 0, leading to deadlock. * After parallel precompile noticed a failure, it would crash, instead of allowing the program to continue on to load the package normally. We had tests for this, but they had gotten removed. (cherry picked from commit f362f47)
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isprecompiledimplementation failed to account for the preferred stdlib logic of loading.isprecompiledcache failed to account for either newly compiled packages or other changes to the file system.Marked as draft since this is against the quieter-logging PR (#59652).