Skip to content

specialize show of : to make reshape trimmable #59598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

specialize show of : to make reshape trimmable #59598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions base/essentials.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,6 +1054,10 @@ struct Colon <: Function
end
const (:) = Colon()

function show(io::IO, ::Colon)
show_type_name(io, Colon.name)
print(io, "()")
end

"""
Val(c)
Expand Down
1 change: 0 additions & 1 deletion contrib/juliac/juliac-trim-base.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ end
print(io, T.var.name)
end
end
show_type_name(io::IO, tn::Core.TypeName) = print(io, tn.name)
# this function is not `--trim`-compatible if it resolves to a Varargs{...} specialization
# and since it only has 1-argument methods this happens too often by default (just 2-3 args)
setfield!(typeof(throw_eachindex_mismatch_indices).name, :max_args, Int32(5), :monotonic)
Expand Down
2 changes: 2 additions & 0 deletions test/trimming/trimmability.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,7 @@ function @main(args::Vector{String})::Cint
catch
end

Base.donotdelete(reshape([1,2,3],:,1,1))

return 0
end