sizeof(::Array): typeassert ::Int to help abstract type inference#59417
sizeof(::Array): typeassert ::Int to help abstract type inference#59417nsajko wants to merge 1 commit intoJuliaLang:masterfrom
sizeof(::Array): typeassert ::Int to help abstract type inference#59417Conversation
Fix a regression where abstract return type inference of `sizeof(::Array)` used to produce `Any` after Julia v1.11.
|
I think instead we can delete some of the redundant Array length methods. |
|
This should fix all these issues: |
I know (already opened relevant PRs before), but this seemed like on OK quick fix. Relevant PRs: |
|
In particular, an issue with the proposed diff above @JeffBezanson, as pointed out in a comment by @KristofferC in one of the linked PRs of mine, is that it would cause new invalidations. That is why now I'm trying to combine deleting unnecessary |
|
However it still might make sense to do the simple |
|
Why does it cause invalidations? I would think adding new methods could not invalidate If it is indeed a problem, maybe keeping the method for Vector will help. |
|
You're right, PR #57627 does not seem to cause any invalidation. I'm moving the tests from these few most recent PRs to that PR. |
Fix a regression where abstract return type inference of
sizeof(::Array)used to produceAnyafter Julia v1.11.