Skip to content

Clarify and enhance confusing precompile test #59170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
+4 −1
Merged

Clarify and enhance confusing precompile test #59170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/precompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,10 @@ precompile_test_harness(false) do dir
error("the \"break me\" test failed")
catch exc
isa(exc, ErrorException) || rethrow()
occursin("ERROR: LoadError: break me", exc.msg) && rethrow()
# The LoadError shouldn't be surfaced but is printed to stderr, hence the `@test_warn` capture tests
occursin("LoadError: break me", exc.msg) && rethrow()
# The actual error that is thrown
occursin("Failed to precompile FooBar2", exc.msg) || rethrow()
end

# Test that trying to eval into closed modules during precompilation is an error
Expand Down