Skip to content

REPL: improve type inference for maybe_spawn_cache_PATH #59144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

REPL: improve type inference for maybe_spawn_cache_PATH #59144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions stdlib/REPL/src/REPLCompletions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,19 +334,23 @@ PATH_cache_task::Union{Task,Nothing} = nothing
PATH_cache_condition::Union{Threads.Condition, Nothing} = nothing # used for sync in tests
next_cache_update::Float64 = 0.0
function maybe_spawn_cache_PATH()
global PATH_cache_task, next_cache_update
global PATH_cache_task, PATH_cache_condition, next_cache_update
# Extract to local variables to enable flow-sensitive type inference for these global variables
PATH_cache_task_local = PATH_cache_task
PATH_cache_condition_local = PATH_cache_condition
@lock PATH_cache_lock begin
PATH_cache_task isa Task && !istaskdone(PATH_cache_task) && return
PATH_cache_task_local isa Task && !istaskdone(PATH_cache_task_local) && return
time() < next_cache_update && return
PATH_cache_task = Threads.@spawn begin
REPLCompletions.cache_PATH()
@lock PATH_cache_lock begin
next_cache_update = time() + 10 # earliest next update can run is 10s after
PATH_cache_task = nothing # release memory when done
PATH_cache_condition !== nothing && notify(PATH_cache_condition)
PATH_cache_condition_local !== nothing && notify(PATH_cache_condition_local)
end
end
Base.errormonitor(PATH_cache_task)
PATH_cache_task_local = PATH_cache_task
Base.errormonitor(PATH_cache_task_local)
end
end

Expand Down